[DCJ-11][risk=no] duos-ui runs all PR checks on Dependabot PRs #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot was added to duos-ui before there was a way for Dependabot to access repository secrets. The workaround was to skip UI integration tests in Dependabot PRs, along with any other task requiring secret access. Once the changes from https://github.com/broadinstitute/terraform-ap-deployments/pull/1486 we can change PR checks so that they all run on Dependabot PRs.
|
Moving to draft: these integration tests are configured to run on Alpha, and have been disabled for the past 5 months. We should decide whether we want to update them to run on a different environment as part of PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-11
Summary
Dependabot was added to duos-ui before there was a way for Dependabot to access repository secrets. The workaround was to skip UI integration tests in Dependabot PRs, along with any other task requiring secret access.
Once the changes from https://github.com/broadinstitute/terraform-ap-deployments/pull/1486 we can change PR checks so that they all run on Dependabot PRs.
Have you read Terra's Contributing Guide lately? If not, do that first.